Fix precision mishandling and more clang warning #2375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ye-luo
changed the title
prckent
approved these changes
Apr 10, 2020
There was a problem hiding this comment.
LGTM. ALCF CI is having checkout problems. Manual CI is OK:
--- START build_gccnew Fri Apr 10 13:59:42 EDT 2020
100% tests passed, 0 tests failed out of 38
--- START build_gcccuda Fri Apr 10 14:02:23 EDT 2020
100% tests passed, 0 tests failed out of 36
--- START build_gcccuda_full Fri Apr 10 14:04:43 EDT 2020
100% tests passed, 0 tests failed out of 36
--- START build_gcccuda_complex Fri Apr 10 14:07:05 EDT 2020
100% tests passed, 0 tests failed out of 49
--- START build_gccnew_complex Fri Apr 10 14:09:35 EDT 2020
100% tests passed, 0 tests failed out of 51
--- START build_gccnew_nompi Fri Apr 10 14:12:32 EDT 2020
100% tests passed, 0 tests failed out of 26
--- START build_gccnew_nompi_complex Fri Apr 10 14:14:26 EDT 2020
100% tests passed, 0 tests failed out of 26
--- START build_clangnew Fri Apr 10 14:16:14 EDT 2020
100% tests passed, 0 tests failed out of 38
--- START build_clangnew_complex Fri Apr 10 14:18:43 EDT 2020
100% tests passed, 0 tests failed out of 51
--- START build_clangnew_mixed Fri Apr 10 14:21:19 EDT 2020
97% tests passed, 1 tests failed out of 38
--- START build_clangnew_complex_mixed Fri Apr 10 14:23:46 EDT 2020
98% tests passed, 1 tests failed out of 51
--- START build_clangnew_aos Fri Apr 10 14:26:27 EDT 2020
100% tests passed, 0 tests failed out of 36
--- START build_clangnew_complex_aos Fri Apr 10 14:28:57 EDT 2020
100% tests passed, 0 tests failed out of 49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fix precision mishandling and more clang warning (actually bugs)
What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
bora
Checklist