Feature: LookupRangeCheck trait and minor improvements #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is now possible to create a Point from a constant.
This functionality is required to evaluate the old nullifier.
- for non split_notes, nf_old = Extract_P([PRF^{nfOrchard}_{nk}(rho_old) + psi_nf) mod q_P] NullifierK + cm_old)
- for split notes, nf_old = Extract_P([PRF^{nfOrchard}_{nk}(rho_old) + psi_nf) mod q_P] NullifierK + cm_old + NullifierL)
Short range checks on 4 and 5 bits are now performed with only one lookup (instead of 2). To do that, we added a column `table_short_range_tag` in the lookup table. This new column `table_short_range_tag` contains the value - 4 for rows used in short range check on 4 bits - 5 for rows used in short range check on 5 bits - 0 for rows used in short range check on 10 bits Disable tests on i686 and code coverage in CI
It is now possible to perform a mux between two points or between two non-identity points.
`mux(choice, left, right)` will return `left` when `choice=0` and `right` when `choice=1`.
`choice` must be constrained to `{0, 1}` outside the gate.
It is no longer needed to expose `from_coordinates_unchecked`.
…oint (#22) To share ZEC and ZSA hash computations in Orchard circuit's note commitment evaluation, we need to compute a Sinsemille hash from a private input point.
…senting the circuit) is as expected
…dd and use PallasLookupConfig type alias for LookupRangeCheckConfigspecialized with pallas::Base and sinsemilla::K
…mes of the test data files to follow the same convention: .proof.bin for proof tests, .vk.txt for verifying key/layout tests
PaulLaux
reviewed
May 16, 2024
There was a problem hiding this comment.
Added some comments, mostly about style.
In addition,
.vk.txtdoes not work, let's prefix with:vk_short_range_check.rdata.proof.bindoes not work, let's prefixproof_short_range_check_1.bin. Also, all proof files should have an index since they are not canonical (unlike vk)
… see if it helps to resolve test failing on GitHub
…mpatibility This change adds default generic arguments for types implementing the PallasLookup trait, assigning them to PallasLookupConfig by default. This adjustment allows existing code to function without requiring users to explicitly specify PallasLookupConfig, thus minimizing breaking changes. Users will still need to bring the PallasLookup trait into scope using 'use ... PallasLookup'.
…ric-arg' into improve-backward-compatability-without-zsa
…om:QED-it/halo2 into improve-backward-compatability-without-zsa
…rcuit Previously, the functions test_against_stored_vk and test_against_stored_proof each generated a verification key (vk). This operation can be quite slow. We are combining these two tests to generate the vk only once.
PallasLookupRangeCheck <- PallasLookupRC PallasLookupRangeCheckConfig <- PallasLookupRCConfig
|
Replaced by #32 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key Changes from zcash/halo2 v0.3.0
LookupRangeChecktrait that provides common methods for a lookup range check.EccConfig(EccChip, SinsemillaConfig, SinsemillaChip, MerkleConfig, MerkleChip) to include additional functionalities provided by the Lookup typeEccPointQenum to handle either type of point forQ.MerkleSinsemillaInstructionstrait to extend the capabilities ofSinsemillaInstructions, for specific cryptographic operations involving generic lookup.test_utils.rsto implement functions used for circuit tests.tests/circuit_datafolder.PallasLookupRCConfigby default. This adjustment allows existing code to function without requiring users to explicitly specify PallasLookupRCConfig, thus minimizing breaking changes. Users will still need to bring the PallasLookupRC trait into scope using 'use ... PallasLookupRC'.