Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functions to evaluate a Sinsemilla hash from an initial private point #22

Merged
merged 3 commits into from
Oct 18, 2023

Conversation

ConstanceBeguier
Copy link

@ConstanceBeguier ConstanceBeguier commented Oct 5, 2023

To share ZEC and ZSA hash computations in Orchard circuit's note commitment evaluation, we need to compute a Sinsemille hash from a private input point.

@ConstanceBeguier ConstanceBeguier force-pushed the optimized_zec_zsa_hash branch 2 times, most recently from 8fda1cc to 3c09a6e Compare October 16, 2023 07:30
@ConstanceBeguier ConstanceBeguier changed the base branch from optimized_short_range_check to zsa1 October 16, 2023 07:30
Copy link

@PaulLaux PaulLaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments

halo2_gadgets/src/ecc/chip.rs Outdated Show resolved Hide resolved
halo2_gadgets/src/sinsemilla.rs Outdated Show resolved Hide resolved
halo2_gadgets/src/sinsemilla.rs Show resolved Hide resolved
@ConstanceBeguier ConstanceBeguier merged commit 3c14fe4 into zsa1 Oct 18, 2023
34 checks passed
ConstanceBeguier added a commit that referenced this pull request Oct 19, 2023
…oint (#22)

To share ZEC and ZSA hash computations in Orchard circuit's note commitment evaluation, we need to compute a Sinsemille hash from a private input point.
ConstanceBeguier added a commit that referenced this pull request Nov 23, 2023
…oint (#22)

To share ZEC and ZSA hash computations in Orchard circuit's note commitment evaluation, we need to compute a Sinsemille hash from a private input point.
ConstanceBeguier added a commit that referenced this pull request Dec 7, 2023
…oint (#22)

To share ZEC and ZSA hash computations in Orchard circuit's note commitment evaluation, we need to compute a Sinsemille hash from a private input point.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants