Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor package info to setup.cfg, run pyupgrade #34

Merged
merged 2 commits into from
May 16, 2022

Conversation

mmerickel
Copy link
Member

No description provided.

Copy link
Member

@digitalresistor digitalresistor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some things I saw, unless you want to address them elsewhere?

e.args = tuple(args)
e.message = args[0]
raise

class InterpolateWrapper(object):
class InterpolateWrapper:
# Python >= 3.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a Python less than 3 branch here somewhere?

I'm on mobile!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, removed that code

@@ -102,7 +102,7 @@ def before_get(self, parser, section, option, value, defaults):
except Exception:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a really yucky way to reraise with a changed exception message.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, not going to try to clean it up right now though :-)

version = 2.1.1
author = Ian Bicking
author_email = pylons-discuss@googlegroups.com
maintainer = Chris Dent
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be changed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dunno, would have to find out if chris is around - going to leave it as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants