Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub Actions and support only Python 3 #16

Merged
merged 1 commit into from
May 16, 2024

Conversation

pfw
Copy link
Contributor

@pfw pfw commented Dec 20, 2022

This is based on the Pyramid GitHub actions but with some of the OS/architecture combinations removed to reduce the time and so limit the use of free CPU minutes - Windows could be added back in if required by users.

Additionally Pyramid has steps around linting and formatting of code which would be nice to add to make things consistent but doing all of that in one change is likely a bit much.

The changes affect testing at this point, there further changes which can drop Python 2 compatibility code in the main code but at this point a new release isn't appropriate.

- use Pylons/pyramid GitHub Actions as a base but don't run all of the OS/architecture combinations
- support up to 3.12-dev (on Linux)
- drop 2.7 and 3.6
- fixes for coverage when 2.7 isn't used
- support pytest changes around returning a test case/suite
- add tox environments for pypy
Copy link
Member

@digitalresistor digitalresistor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor nits. thanks for putting this PR together!

hypatia/query/__init__.py Show resolved Hide resolved
tox.ini Show resolved Hide resolved
Copy link
Member

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pfw Thanks very much for this patch, and apologies for letting it languish!.

hypatia/query/__init__.py Show resolved Hide resolved
tox.ini Show resolved Hide resolved
@tseaver tseaver merged commit d195029 into Pylons:master May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants