Add support for multiple loggers #903
Conversation
|
Hello @ethanwharris! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 馃嵒 Comment last updated at 2020-02-25 18:55:02 UTC |
pytorch_lightning/loggers/base.py
Outdated
|
|
||
| @property | ||
| def experiment(self): | ||
| return [logger.experiment() for logger in self._logger_list] |
There was a problem hiding this comment.
this may be tricky since it returns list instead object...
There was a problem hiding this comment.
Yeah, this is really just a precaution anyway as we don't use the experiment property internally. However, the experiment property is a different object for every logger so I think this is acceptable
There was a problem hiding this comment.
I know, but we do not know about all user usage of these loggers lol
There was a problem hiding this comment.
I'm not sure there's any other option here, any suggestions?
|
we shall resolve the MNIST issue very soon #859 |
|
Ok, have fixed those issues - this should be ready to go :) |
|
Perfect, but rather I would wait till master is fixed, @williamFalcon #938 |
|
@ethanwharris @Borda tests are fixed. let's rebase! |
|
@williamFalcon done but does not show any change, strange... |
|
@Borda That should have fixed it, hopefully the tests will run now :) |
|
@ethanwharris this is awesome. Can you also make the appropriate changes to: |
|
@williamFalcon Done :) |
|
@ethanwharris amazing! |
|
@ethanwharris Very nice addition!! You even annotated the types :) |
|
@ethanwharris is making our code look sloppy by comparison haha. |
* Add support for multiple loggers * Fix PEP * Cleanup * Cleanup * Add typing to loggers * Update base.py * Replace duck typing with isinstance check * Update CHANGELOG.md * Update comet experiment type, Switch to abstractmethod in logging.py * Fix test * Add passes to LightningLoggerBase * Update experiment_logging.rst
Before submitting
What does this PR do?
Fixes #317
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 馃檭