Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tests #938

Merged
merged 2 commits into from
Feb 25, 2020
Merged

fix tests #938

merged 2 commits into from
Feb 25, 2020

Conversation

williamFalcon
Copy link
Contributor

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
  • Did you read the contributor guideline?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

Fixes # (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@williamFalcon williamFalcon mentioned this pull request Feb 25, 2020
@MattPainter01
Copy link
Contributor

MattPainter01 commented Feb 25, 2020

The test I put also tries to run a test when only test_end is implemented. Should just be able to move that test inside a raises MisConfigException to fix these errors, if we require test_step.

Specifically, this line:
https://github.com/PyTorchLightning/pytorch-lightning/blob/6b667b1237f8ed74db920a2c1c49d55ca1d2b7e5/tests/test_trainer.py#L809

@Borda Borda mentioned this pull request Feb 25, 2020
5 tasks
@williamFalcon williamFalcon merged commit ceec51d into master Feb 25, 2020
@Borda Borda added bug Something isn't working need fix labels Feb 27, 2020
@Borda Borda added this to the 0.6.1 milestone Feb 27, 2020
@williamFalcon williamFalcon deleted the fix_tests branch February 28, 2020 21:00
tullie pushed a commit to tullie/pytorch-lightning that referenced this pull request Apr 3, 2020
* fix tests

* fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants