Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated args to learning rate step function #890

Merged
merged 1 commit into from
Feb 19, 2020
Merged

remove deprecated args to learning rate step function #890

merged 1 commit into from
Feb 19, 2020

Conversation

SkafteNicki
Copy link
Member

Before submitting

  • [x ] Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
  • [x ] Did you read the contributor guideline?
  • [x ] Did you make sure to update the docs?
  • [x ] Did you write any new necessary tests?
  • [x ] If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

Fixes #708.

Removing of the deprecated epoch argument in the .step(...) method of learning rate schedulers. Currently (pytorch 1.4) if the user give a epoch argument, an DeprecationWarning will be thrown. But looking at the pytorch master branch, the warning has been changed to UserWarning meaning that in the future, if the epoch argument is not removed, this will give an warning each time a model with a learning rate scheduler is trained.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Borda Borda added bug Something isn't working good first issue Good for newcomers ready PRs ready to be merged labels Feb 18, 2020
@Borda Borda added this to the 0.6.1 milestone Feb 18, 2020
@williamFalcon williamFalcon merged commit c58aab0 into Lightning-AI:master Feb 19, 2020
@Borda Borda mentioned this pull request Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LR Schedulers shouldn't get epoch argument in step function
3 participants