Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LR Schedulers shouldn't get epoch argument in step function #708

Closed
felixkreuk opened this issue Jan 18, 2020 · 4 comments · Fixed by #890
Closed

LR Schedulers shouldn't get epoch argument in step function #708

felixkreuk opened this issue Jan 18, 2020 · 4 comments · Fixed by #890
Assignees
@Borda
Labels
bug Something isn't working good first issue Good for newcomers
Milestone
pl:0.7

Comments

@felixkreuk
Copy link

🐛 Bug

PyTorch LR schedulers now shouldn't get any arguments in step function, see here and here.

Looks like the calls in PytorchLightning are not in line with the new interface, see here.

This results in unexpected LR changes. Removing the epoch argument from step call solves the issue for me.

Environment

PyTorch 1.4
PyTorchLightning 0.5.3.2
@felixkreuk felixkreuk added the bug Something isn't working label Jan 18, 2020
@williamFalcon
Copy link
Contributor

good catch. we need to keep it backward compatible though

@Borda
Copy link
Member

Borda commented Jan 18, 2020

We shall catch it with a test...

@williamFalcon
Copy link
Contributor

@Borda want to submit PR for this?

@williamFalcon
Copy link
Contributor

@felixkreuk want to submit a PR?

@williamFalcon williamFalcon added this to the 0.6.1 milestone Feb 11, 2020
@SkafteNicki SkafteNicki mentioned this issue Feb 18, 2020
Merged
@Borda Borda added the good first issue Good for newcomers label Feb 18, 2020
@Borda Borda self-assigned this Feb 18, 2020
@Borda Borda mentioned this issue Feb 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Borda Borda

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
pl:0.7
Development

Successfully merging a pull request may close this issue.

remove deprecated args to learning rate step function
3 participants
@williamFalcon @Borda @felixkreuk