Tensorboard path generalisation #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
requested changes
Feb 8, 2020
Borda
added
feature
Allow experiment names to be empty, in which case no per-experiment subdirectory will be created and checkpoints will be saved in the directory given by the save_dir parameter.
|
FYI, I slightly simplified my test. It still tests as much as the existing ones but doesn't check for the tensorboard output directory being created. Perhaps tensorboard doesn't create it immediately when saving in earlier versions. I couldn't get it to fail locally and it works for non-minimal versions. |
Borda
reviewed
Feb 8, 2020
| version (int): Experiment version. If version is not specified the logger inspects the save | ||
| name (str): Experiment name. Defaults to "default". If it is the empty string then no per-experiment | ||
| subdirectory is used. | ||
| version (int|str): Experiment version. If version is not specified the logger inspects the save | ||
| directory for existing versions, then automatically assigns the next available version. |
There was a problem hiding this comment.
this should have extra tab spacing as it belongs as a block to an argument
| @property | ||
| def root_dir(self): | ||
| """ Parent directory for all tensorboard checkpoint subdirectories. | ||
| If the experiment name parameter is None or the empty string, no experiment subdirectory is used |
There was a problem hiding this comment.
I think it now follows the format used elsewhere. We're getting there.
There was a problem hiding this comment.
the point/issue is that still do not have unified formatting everywhere yet...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Fixes issue 793
You can (say) specify the version on the command line or generate it from the current datetime, which I find more meaningful than "version_73".
Likewise if the tensorboard data is not going to be preserved, it's much more readable in the tensorboard gui to skip the experiment name.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
I learnt some things