Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More flexible paths for saving tensorboard data #793

Closed
bobkemp opened this issue Feb 5, 2020 · 3 comments
Closed

More flexible paths for saving tensorboard data #793

bobkemp opened this issue Feb 5, 2020 · 3 comments
Labels
feature Is an improvement or enhancement help wanted Open to be worked on
Milestone

Comments

@bobkemp
Copy link
Contributor

bobkemp commented Feb 5, 2020

🚀 Feature

I'd like more flexibility in the directory hierarchy used for writing tensorboard data.
Specifically, I want to make the experiment-name directory optional, removing one level in the hierarchy.

Also I'd like to be able to specify the name of the version directory. Currently it is "version_N" but if the constructor version parameter is a string, I think it could just directly use that.

Motivation

You could specify the version on the command line or generate it from the current datetime, which I find more meaningful than "version_73". Likewise if the tensorboard data is not going to be preserved, it's much more readable in the tensorboard gui to skip the experiment name.

Pitch

I have a branch with working code + tests

https://github.com/bobkemp/pytorch-lightning/tree/tensorboard-path-generalisation

Alternatives

None

Additional context

@bobkemp bobkemp added feature Is an improvement or enhancement help wanted Open to be worked on labels Feb 5, 2020
@williamFalcon
Copy link
Contributor

@bobkemp could you post examples and use cases of what you mean? also, you can submit a PR to make the changes easier to see.

@bobkemp
Copy link
Contributor Author

bobkemp commented Feb 8, 2020

Here's the directory layout you could have and how it appears in TensorBoard.
I think the change also cleans up the code a little, removing duplication.

pr793-changes

Without experiments directory:
TensorBoardLogger(tensorboard_dir, name="")

checkpoints/version_0
checkpoints/version_0/events.out.tfevents.1581113035.glia.8401.0
checkpoints/version_0/meta_tags.csv

Without experiments directory and with explicitly named version directory:
TensorBoardLogger(tensorboard_dir, name="", version="2020-02-07-220525")
checkpoints/2020-02-07-220525
checkpoints/2020-02-07-220525/events.out.tfevents.1581113127.glia.8438.0
checkpoints/2020-02-07-220525/meta_tags.csv

Current code:
TensorBoardLogger(tensorboard_dir)
checkpoints/default
checkpoints/default/version_0
checkpoints/default/version_0/events.out.tfevents.1581112657.glia.8299.0
checkpoints/default/version_0/meta_tags.csv
checkpoints/default/version_1
checkpoints/default/version_1/events.out.tfevents.1581112777.glia.8341.0
checkpoints/default/version_1/meta_tags.csv

@bobkemp
Copy link
Contributor Author

bobkemp commented Feb 8, 2020

PR #804

@williamFalcon williamFalcon added this to the 0.6.1 milestone Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement help wanted Open to be worked on
Projects
None yet
Development

No branches or pull requests

2 participants