update batch size in LightningModule.datamodule when auto scaling batch size #3266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 30, 2020 09:33
rohitgr7
reviewed
Aug 30, 2020
awaelchli
changed the title
Codecov Report
@@ Coverage Diff @@
## master #3266 +/- ##
=======================================
- Coverage 90% 86% -4%
=======================================
Files 90 91 +1
Lines 8158 8700 +542
=======================================
+ Hits 7362 7499 +137
- Misses 796 1201 +405 |
7 tasks
|
This pull request is now in conflict... :( |
justusschock
approved these changes
Sep 1, 2020
SkafteNicki
reviewed
Sep 1, 2020
Comment on lines
286
to
287
| if trainer.datamodule is not None and hasattr(trainer.datamodule, batch_arg_name): | ||
| setattr(trainer.datamodule, batch_arg_name, new_size) |
There was a problem hiding this comment.
Is this necessary, should lightning_setattr not take care of this?
There was a problem hiding this comment.
you mean accessing it through model.trainer.datamodule? Ok, I'll try that
Borda
reviewed
Sep 1, 2020
| @@ -186,15 +186,17 @@ def lightning_hasattr(model, attribute): | |||
| attr = attribute in model.hparams | |||
| else: | |||
| attr = hasattr(model.hparams, attribute) | |||
| elif hasattr(model.datamodule, attribute): | |||
There was a problem hiding this comment.
this is a bit confusing regarding the line above... mind adding a comment what is this case about...
Borda
reviewed
Sep 1, 2020
Borda
reviewed
Sep 1, 2020
SkafteNicki
reviewed
Sep 3, 2020
awaelchli
changed the title
awaelchli
changed the title
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
justusschock
approved these changes
Sep 3, 2020
Borda
approved these changes
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #3233
the new test fails on master
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 馃檭