Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update batch size in LightningModule.datamodule when auto scaling batch size #3266

Merged
merged 16 commits into from
Sep 3, 2020
Merged

update batch size in LightningModule.datamodule when auto scaling batch size #3266

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
89792d2
fix datamodule hasattr
Aug 30, 2020
5efe8bf
fix patch check
Aug 30, 2020
1874ca1
fix setattr
awaelchli Aug 30, 2020
361e63b
update docs
awaelchli Aug 30, 2020
4fdaac1
revert patch fix
awaelchli Aug 30, 2020
5aa826f
changelog
awaelchli Aug 30, 2020
9e07eb2
fix datamodule passed in as fit arg
awaelchli Aug 30, 2020
130b599
docs
awaelchli Aug 30, 2020
b9ea152
set datamodule batch size in lightning_setattr
awaelchli Sep 2, 2020
4e1a202
Merge branch 'master' into bugfix/dm-batchfinder
awaelchli Sep 2, 2020
4183026
fix merge
awaelchli Sep 2, 2020
224c3c6
check with has_attr
awaelchli Sep 2, 2020
4066b78
access datamodule via trainer
awaelchli Sep 3, 2020
8a5d27b
pass fit args down to tuner
awaelchli Sep 3, 2020
ed6f751
docs
awaelchli Sep 3, 2020
e4df06b
fix typos in docs
awaelchli Sep 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pytorch_lightning/trainer/training_tricks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ def scale_batch_size(self,
f' If this is not the intended behavior, please remove either one.'
)

if hasattr(model.train_dataloader(), 'patch_loader_code'):
if hasattr(model.train_dataloader, 'patch_loader_code'):
rohitgr7 marked this conversation as resolved.
Show resolved Hide resolved
raise MisconfigurationException('The batch scaling feature cannot be used with dataloaders'
' passed directly to `.fit()`. Please disable the feature or'
' incorporate the dataloader into the model.')
Expand Down