Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make progress bar match internal epoch counter #3061

Merged
merged 2 commits into from
Aug 20, 2020

Conversation

ananyahjha93
Copy link
Contributor

Fixes #3018
Fixes #3032

wip: need to finish some tests

@mergify mergify bot requested a review from a team August 20, 2020 00:56
@williamFalcon
Copy link
Contributor

@ananyahjha93 let's wait on this PR haha... #3018 is actually supposed to be fixed at the logger level i think. that's a very complicated GH, let's keep it for later.

@ananyahjha93 ananyahjha93 reopened this Aug 20, 2020
@codecov
Copy link

codecov bot commented Aug 20, 2020

Codecov Report

Merging #3061 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #3061   +/-   ##
======================================
  Coverage      86%     86%           
======================================
  Files          81      81           
  Lines        7700    7700           
======================================
  Hits         6642    6642           
  Misses       1058    1058           

@williamFalcon williamFalcon changed the title [wip] fix 3018, 3032, add more tests for checkpointing and restore make progress bar match internal epoch counter Aug 20, 2020
@williamFalcon williamFalcon merged commit 10150fc into master Aug 20, 2020
@Borda Borda added the feature Is an improvement or enhancement label Aug 20, 2020
@Borda Borda deleted the bugfix/checkpointing branch August 20, 2020 21:44
@Borda Borda added this to the 0.9.0 milestone Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Epoch counting is one-off in multiple instances Add support for changing the checkpoint directories names
3 participants