Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for changing the checkpoint directories names #3018

Closed
edenlightning opened this issue Aug 17, 2020 · 2 comments · Fixed by #3061
Closed

Add support for changing the checkpoint directories names #3018

edenlightning opened this issue Aug 17, 2020 · 2 comments · Fixed by #3061
Assignees
@williamFalcon
Labels
feature Is an improvement or enhancement help wanted Open to be worked on priority: 0 High priority task won't fix This will not be worked on
Milestone
pl:1.1

Comments

@edenlightning
Copy link
Contributor

edenlightning commented Aug 17, 2020 •
edited
Loading

In checkpoint callbacks it always creates a folder called checkpoints in the provided root.
Users should be able to change that name from "checkpoints" to anything else.
@edenlightning edenlightning added bug Something isn't working help wanted Open to be worked on labels Aug 17, 2020
@edenlightning edenlightning added the priority: 0 High priority task label Aug 18, 2020
@edenlightning edenlightning added this to the 0.9.0 milestone Aug 18, 2020
@ananyahjha93 ananyahjha93 self-assigned this Aug 19, 2020
@ananyahjha93 ananyahjha93 added feature Is an improvement or enhancement and removed bug Something isn't working labels Aug 19, 2020
@williamFalcon williamFalcon mentioned this issue Aug 19, 2020
Merged
@ananyahjha93 ananyahjha93 mentioned this issue Aug 20, 2020
Merged
@williamFalcon williamFalcon reopened this Aug 20, 2020
@edenlightning edenlightning modified the milestones: 0.9.0, 0.9.x Aug 20, 2020
@ananyahjha93 ananyahjha93 removed their assignment Aug 20, 2020
@edenlightning
Copy link
Contributor Author

@williamFalcon what is left to do?

@edenlightning edenlightning modified the milestones: 0.9.x, 1.1 Sep 23, 2020
@stale
Copy link

stale bot commented Nov 3, 2020

This issue has been automatically marked as stale because it hasn't had any recent activity. This issue will be closed in 7 days if no further activity occurs. Thank you for your contributions, Pytorch Lightning Team!

@stale stale bot added the won't fix This will not be worked on label Nov 3, 2020
@stale stale bot closed this as completed Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@williamFalcon williamFalcon

Labels
feature Is an improvement or enhancement help wanted Open to be worked on priority: 0 High priority task won't fix This will not be worked on
Projects
None yet
Milestone
pl:1.1
Development

Successfully merging a pull request may close this issue.

make progress bar match internal epoch counter Lightning-AI/pytorch-lightning
3 participants
@williamFalcon @ananyahjha93 @edenlightning