added reduce ddp results on eval #2434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamFalcon
force-pushed
the
val_reduce
branch
from
069a8a3
to
63648b8
Compare
|
Hello @williamFalcon! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-06-30 19:19:32 UTC |
awaelchli
reviewed
Jun 30, 2020
| @@ -347,6 +354,22 @@ def _evaluate( | |||
|
|
|||
| return eval_results | |||
|
|
|||
| def reduce_eval_ddp(self, eval_results): | |||
There was a problem hiding this comment.
this traversal of nested types looks like what @justusschock did in metrics. maybe one could re-use his apply_to_collection from utilitiles.apply_func.py
There was a problem hiding this comment.
good point @justusschock how would i adapt that here?
There was a problem hiding this comment.
Quick brain-compiled code:
eval_results = apply_to_collection(
eval_results,
dtype=torch.Tensor,
function=reduce_eval_ddp,
world_size=self.world_size
)with reduce_eval_ddp defined as
def reduce_eval_ddp(v, world_size):
dist.all_reduce(v, op=dist.reduce_op.SUM)
v = v / world_size
return v
Codecov Report
@@ Coverage Diff @@
## master #2434 +/- ##
======================================
- Coverage 89% 88% -0%
======================================
Files 69 69
Lines 5485 5499 +14
======================================
+ Hits 4858 4862 +4
- Misses 627 637 +10 |
This was referenced Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement: aggregates ddp outputs on eval
Fixes #702