-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added reduce ddp results on eval #2434
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
9d1c5f9
added reduce ddp results on eval
williamFalcon 03ef084
added reduce ddp results on eval
williamFalcon 63648b8
added reduce ddp results on eval
williamFalcon 44fc0a4
added reduce ddp results on eval
williamFalcon 1c818f6
added reduce ddp results on eval
williamFalcon feb3431
added reduce ddp results on eval
williamFalcon f4fabeb
added reduce ddp results on eval
williamFalcon 381a08a
added reduce ddp results on eval
williamFalcon 3b4c7bd
added reduce ddp results on eval
williamFalcon b2d119c
added reduce ddp results on eval
williamFalcon 7c205cf
added reduce ddp results on eval
williamFalcon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this traversal of nested types looks like what @justusschock did in metrics. maybe one could re-use his
apply_to_collection
fromutilitiles.apply_func.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point @justusschock how would i adapt that here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick brain-compiled code:
with
reduce_eval_ddp
defined as