fix loading with hparams

[Borda]

What does this PR do?

Fixes #2386
Fixes #2364

Before submitting

• Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
• Did you read the contributor guideline, Pull Request section?
• Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
• Did you make sure to update the documentation with your changes?
• Did you write any new necessary tests?
• Did you verify new and existing tests pass locally with your changes?
• If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

[pep8speaks]

Hello @Borda! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-06-28 21:31:09 UTC

[codecov]

Codecov Report

Merging #2403 into master will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #2403   +/-   ##
======================================
  Coverage      88%     88%           
======================================
  Files          69      69           
  Lines        5473    5474    +1     
======================================
+ Hits         4839    4841    +2     
+ Misses        634     633    -1     

[mergify]

This pull request is now in conflict... :(

[rolanddenis]

Thanks for this PR! It also fix an issue I have loading a child module (like in #1427 but using keywords for __init__ and using save_hyperparameters) with hyper parameters defined in child and parent class (using **kwargs for the parameters passed to the parent class). The hyper parameters for the parent class was not passed to the constructor of the child.