Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix loading with hparams #2403

Merged
merged 6 commits into from
Jun 29, 2020
Merged

fix loading with hparams #2403

merged 6 commits into from
Jun 29, 2020

Conversation

Borda
Copy link
Member

@Borda Borda commented Jun 28, 2020

What does this PR do?

Fixes #2386
Fixes #2364

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the bug Something isn't working label Jun 28, 2020
@Borda Borda added this to the 0.8.x milestone Jun 28, 2020
@pep8speaks
Copy link

pep8speaks commented Jun 28, 2020

Hello @Borda! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-06-28 21:31:09 UTC

@mergify mergify bot requested a review from a team June 28, 2020 19:17
@Borda Borda marked this pull request as ready for review June 28, 2020 19:53
@codecov
Copy link

codecov bot commented Jun 28, 2020

Codecov Report

Merging #2403 into master will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #2403   +/-   ##
======================================
  Coverage      88%     88%           
======================================
  Files          69      69           
  Lines        5473    5474    +1     
======================================
+ Hits         4839    4841    +2     
+ Misses        634     633    -1     

@mergify
Copy link
Contributor

mergify bot commented Jun 28, 2020

This pull request is now in conflict... :(

@williamFalcon williamFalcon merged commit 1e16681 into master Jun 29, 2020
@Borda Borda deleted the bugfix/hparams branch June 29, 2020 05:51
@rolanddenis
Copy link

Thanks for this PR! It also fix an issue I have loading a child module (like in #1427 but using keywords for __init__ and using save_hyperparameters) with hyper parameters defined in child and parent class (using **kwargs for the parameters passed to the parent class). The hyper parameters for the parent class was not passed to the constructor of the child.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
4 participants