Checking if the parameters are a DictConfig Object

[ssakhavi]

#614
Before submitting

• Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
• Did you read the contributor guideline, Pull Request section?
• Did you make sure to update the docs?
• Did you write any new necessary tests?
• If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

Fixes #2058 .

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

To be honest, I have no idea how I should go about writing a test for this.

[ssakhavi]

@Borda
The change you proposed caused some of the tests to not pass. Do you know the reason?

[Borda]

The change you proposed caused some of the tests to not pass. Do you know the reason?

you need to propagate the change in your code, like test Container instead of DictConfig

[Borda]

in fact, the solution shall be that DictConfig is inherited from dict, so no change needed for PL

[Borda]

cc: @omry @williamFalcon

[ssakhavi]

A question:

If DictConfig inherits from Dict and the isinstance method wasn't working in the crashing version, why should the MutableMapping work now? Wouldn't it be the same situation?

[omry]

A question:

If DictConfig inherits from Dict and the isinstance method wasn't working in the crashing version, why should the MutableMapping work now? Wouldn't it be the same situation?

DictConfig inherits from MutableMapping as of OmegaConf 2.0 which comes the Hydra 1.0 release candidate.
If you are using Hydra 0.11.3 you should switch to Hydra 1.0.0rc1 (or newer one they are released) for this to work.