Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checking if the parameters are a DictConfig Object #2216

Merged
merged 3 commits into from
Jun 23, 2020
Merged

Checking if the parameters are a DictConfig Object #2216

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6709088
Checking if the parameters are a DictConfig Object
ssakhavi Jun 17, 2020
fbdb41d
Update pytorch_lightning/loggers/base.py
ssakhavi Jun 17, 2020
33deec2
fix ...
Borda Jun 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions pytorch_lightning/loggers/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,11 @@
import operator
from abc import ABC, abstractmethod
from argparse import Namespace
from typing import Union, Optional, Dict, Iterable, Any, Callable, List, Sequence, Mapping, Tuple
from typing import Union, Optional, Dict, Iterable, Any, Callable, List, Sequence, Mapping, Tuple, MutableMapping

import numpy as np
import torch

from pytorch_lightning.utilities import rank_zero_only


class LightningLoggerBase(ABC):
"""
Expand Down Expand Up @@ -174,9 +172,9 @@ def _flatten_dict(params: Dict[str, Any], delimiter: str = '/') -> Dict[str, Any

def _dict_generator(input_dict, prefixes=None):
prefixes = prefixes[:] if prefixes else []
if isinstance(input_dict, dict):
if isinstance(input_dict, MutableMapping):
for key, value in input_dict.items():
if isinstance(value, (dict, Namespace)):
if isinstance(value, (MutableMapping, Namespace)):
value = vars(value) if isinstance(value, Namespace) else value
for d in _dict_generator(value, prefixes + [key]):
yield d
Expand Down