Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(semseg): allow model customization #1338

Closed
wants to merge 4 commits into from

Conversation

borisdayma
Copy link
Contributor

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
    not applicable
  • Did you write any new necessary tests?
    not applicable
  • If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

Allow more customization to the semantic segmentation example:

  • test set has been replace with a validation set to measure model performance
  • both training and validation losses are logged
  • unet allows for more customization: number of layers and number of features
  • masks have been updated to be compatible with the most recent version of the dataset which contains more labels (additional labels are just ignored)
  • script allows for other arguments: distributed backend, 16 bit, number of layers and features for unet as well as type of upsampling, gradient accumulation, number of epochs, logging on W&B

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@pep8speaks
Copy link

pep8speaks commented Apr 2, 2020

Hello @borisdayma! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-04-02 05:56:13 UTC

@mergify mergify bot requested a review from a team April 2, 2020 03:08
@borisdayma
Copy link
Contributor Author

Note: this example requires #1311

@codecov
Copy link

codecov bot commented Apr 2, 2020

Codecov Report

Merging #1338 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1338   +/-   ##
======================================
  Coverage      92%     92%           
======================================
  Files          62      62           
  Lines        3239    3239           
======================================
  Hits         2966    2966           
  Misses        273     273

@borisdayma
Copy link
Contributor Author

The build error related to "examples" mentions problem of relative import which was already there before. Not sure if you want to change it. I think it's clean this way.

@Borda Borda changed the title feat(semseg): allow model customization [blocked by #1311] feat(semseg): allow model customization Apr 2, 2020
@mergify
Copy link
Contributor

mergify bot commented Apr 3, 2020

This pull request is now in conflict... :(

@williamFalcon
Copy link
Contributor

@borisdayma #1311 has been merged! no longer a blocker. please rebase and resubmit PR.

@Borda Borda changed the title [blocked by #1311] feat(semseg): allow model customization feat(semseg): allow model customization Apr 3, 2020
@Borda Borda added the feature Is an improvement or enhancement label Apr 3, 2020
@borisdayma
Copy link
Contributor Author

I think this PR can now be closed in favor of #1371.

@Borda Borda closed this Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants