Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(wandb): fix watch method #1311

Closed
wants to merge 4 commits into from
Closed

fix(wandb): fix watch method #1311

wants to merge 4 commits into from

Conversation

borisdayma
Copy link
Contributor

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
    Discussed in PR 1193
  • Did you read the contributor guideline, Pull Request section?
  • [] Did you make sure to update the docs?
    Not needed here
  • Did you write any new necessary tests?
  • If you made a notable change (that affects users), did you update the CHANGELOG?
    Minor change

What does this PR do?

Allow use of the watch method without importing wandb

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot requested a review from a team March 30, 2020 23:27
@Borda Borda added the bug Something isn't working label Mar 30, 2020
@Borda Borda added this to the 0.7.2 milestone Mar 30, 2020
@codecov
Copy link

codecov bot commented Mar 31, 2020 •
edited
Loading

Codecov Report

Merging #1311 into master will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #1311   +/-   ##
======================================
  Coverage      92%     92%           
======================================
  Files          62      62           
  Lines        3210    3181   -29     
======================================
- Hits         2949    2923   -26     
+ Misses        261     258    -3

Borda
Borda approved these changes Mar 31, 2020
View reviewed changes
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Borda Borda added the ready PRs ready to be merged label Mar 31, 2020
@Borda
Copy link
Member

Borda commented Mar 31, 2020

@borisdayma could you please add note do changelog?

@mergify
Copy link
Contributor

mergify bot commented Mar 31, 2020

This pull request is now in conflict... :(

@borisdayma borisdayma mentioned this pull request Apr 2, 2020
Closed
5 tasks
@Borda Borda requested review from ethanwharris, MattPainter01 and a team April 2, 2020 22:40
Borda
Borda reviewed Apr 2, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@mergify mergify bot requested a review from a team April 2, 2020 22:43
@Borda Borda requested a review from jeremyjordan April 2, 2020 22:54
@Borda Borda requested a review from a team April 3, 2020 07:23
@williamFalcon williamFalcon mentioned this pull request Apr 3, 2020
Merged
@williamFalcon
Copy link
Contributor

Closed in favor of #1361

@Borda Borda modified the milestones: v0.7., v0.7.x Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@justusschock justusschock justusschock approved these changes

@ethanwharris ethanwharris Awaiting requested review from ethanwharris

@MattPainter01 MattPainter01 Awaiting requested review from MattPainter01

@jeremyjordan jeremyjordan Awaiting requested review from jeremyjordan

Assignees
No one assigned
Labels
bug Something isn't working ready PRs ready to be merged
Projects
None yet
Milestone
pl:0.7.x
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@borisdayma @Borda @williamFalcon @justusschock