self.forward() -> self() #1211

jeremyjordan · 2020-03-22T22:49:45Z

Before submitting

Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
Did you read the contributor guideline, Pull Request section?
Did you make sure to update the docs?
Did you write any new necessary tests?
If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

codecov · 2020-03-22T23:21:09Z

Codecov Report

Merging #1211 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1211   +/-   ##
======================================
  Coverage      91%     91%           
======================================
  Files          61      61           
  Lines        3153    3153           
======================================
  Hits         2879    2879           
  Misses        274     274

Borda

LFTM 🚀

williamFalcon · 2020-03-24T18:48:50Z

@jeremyjordan what about the TPU issue?

mergify · 2020-03-24T18:53:44Z

This pull request is now in conflict... :(

jeremyjordan · 2020-03-24T22:33:28Z

can’t edit the title on mobile but this is WIP until TPU issue is resolved

jeremyjordan · 2020-03-25T03:06:07Z

@williamFalcon can you share more details about the TPU issue you ran into? i tried running the lightning_mnist_tpu notebook with this branch (and changing self.forward() to self() in the notebook) and it's running fine for me

https://colab.research.google.com/drive/1CtGZs06fDUmNES4PsguTFZw5VbHnt8-k

mergify · 2020-03-25T11:47:17Z

This pull request is now in conflict... :(

ethanwharris

LGTM :)

mergify · 2020-03-27T01:53:09Z

Great job! =)

mergify · 2020-03-27T02:10:55Z

Great job! =)

mergify · 2020-03-27T02:10:55Z

Great job! =)

mergify · 2020-03-27T02:11:14Z

Great job! =)

mergify · 2020-03-27T02:11:14Z

Great job! =)

jeremyjordan · 2020-03-27T02:14:47Z

@Borda any idea what's up with the mergify bot?

mergify · 2020-03-27T07:08:15Z

Great job! =)

Borda · 2020-03-27T07:11:13Z

@jeremyjordan we have there the following rule:

(on head branch) $ git rebase base
(on head branch) # Wait for CI to go green
(on head branch) # Squash all commits
(on base branch) $ git merge --ff head

looking to the master, it seems that there is some conflict with rebasing

Resolve all conflicts manually, mark them as resolved with
"git add/rm <conflicted_files>", then run "git rebase --continue".
You can instead skip this commit: run "git rebase --skip".
To abort and get back to the state before "git rebase", run "git rebase --abort".

see here it worked properly #1251 (comment)

* Example: Simple RL example using DQN/Lightning * DQN RL Agent using Lightning * Uses Iterable Dataset for Replay Buffer * Buffer is populated by agent as training is carried out, updating the dataset * Applied autopep8 fixes * * Updated line length from 120 to 110 * Update pl_examples/domain_templates/dqn.py simplify get_device method Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com> * Update pl_examples/domain_templates/dqn.py Re-ordered imports Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com> * CI: split tests-examples (#990) * CI: split tests-examples * tests without template * comment depends * CircleCI typo * add doctest * update test req. * CI tests * setup macOS * longer train * lover pred acc * fix model * rename default model * lower tests acc * typo * imports * fix test optimizer * update calls * fix Win * lower Drone image * fix call * pytorch image * fix test * add dev image * add dev image * update image * drone volume * lint * update test notes * rename tests/models >> tests/base * group models * conftest * optim imports * typos * fix import * fix tests * install AMP * tests * fix import * Clean up * added module docstring * renamed variables to be more descriptive * Added missing docstrings and type annotations * Added gym to example requirements * Added note to changelog * updated example image * update types * rename script * Update CHANGELOG.md Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com> * another rename * Disable validation when val_percent_check=0 (#1251) * fix disable validation * add test * update changelog * update docs for val_percent_check * make "fast training" docs consistent * calling self.forward() -> self() (#1211) * self.forward() -> self() * update changelog Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> * Fix requirements-extra.txt Trains package to release version (#1229) * Fix requirement-extra use released Trains package * Update README.md add Trains and links to the external Visualization section Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> * Remove unnecessary parameters to super() in documentation and source code (#1240) Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> * update deprecation warning (#1258) * update docs for progress bat values (#1253) * lower timeouts for inactive issues (#1250) * update contrib list (#1241) Co-authored-by: William Falcon <waf2107@columbia.edu> * Fix outdated docs (#1227) * Fix typo (#1224) * drop unused Tox (#1242) * system info (#1234) * system info * update big info * test script * update config * rename script * import path * Changed smoothing in tqdm to decrease variability of time remaining between training / eval (#1194) * Example: Simple RL example using DQN/Lightning * DQN RL Agent using Lightning * Uses Iterable Dataset for Replay Buffer * Buffer is populated by agent as training is carried out, updating the dataset * Applied autopep8 fixes * * Updated line length from 120 to 110 * Update pl_examples/domain_templates/dqn.py simplify get_device method Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com> * Update pl_examples/domain_templates/dqn.py Re-ordered imports Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com> * Clean up * added module docstring * renamed variables to be more descriptive * Added missing docstrings and type annotations * Added gym to example requirements * Added note to changelog * update types * rename script * Update CHANGELOG.md Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com> * another rename Co-authored-by: Donal Byrne <Donal.Byrne@xperi.com> Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> Co-authored-by: William Falcon <waf2107@columbia.edu> Co-authored-by: Adrian Wälchli <adrian.waelchli@students.unibe.ch> Co-authored-by: Jeremy Jordan <13970565+jeremyjordan@users.noreply.github.com> Co-authored-by: Martin.B <51887611+bmartinn@users.noreply.github.com> Co-authored-by: Tyler Yep <tyep@stanford.edu> Co-authored-by: Shunta Komatsu <59395084+skmatz@users.noreply.github.com> Co-authored-by: Jack Pertschuk <jackpertschuk@gmail.com>

* self.forward() -> self() * update changelog Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>

* Example: Simple RL example using DQN/Lightning * DQN RL Agent using Lightning * Uses Iterable Dataset for Replay Buffer * Buffer is populated by agent as training is carried out, updating the dataset * Applied autopep8 fixes * * Updated line length from 120 to 110 * Update pl_examples/domain_templates/dqn.py simplify get_device method Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com> * Update pl_examples/domain_templates/dqn.py Re-ordered imports Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com> * CI: split tests-examples (Lightning-AI#990) * CI: split tests-examples * tests without template * comment depends * CircleCI typo * add doctest * update test req. * CI tests * setup macOS * longer train * lover pred acc * fix model * rename default model * lower tests acc * typo * imports * fix test optimizer * update calls * fix Win * lower Drone image * fix call * pytorch image * fix test * add dev image * add dev image * update image * drone volume * lint * update test notes * rename tests/models >> tests/base * group models * conftest * optim imports * typos * fix import * fix tests * install AMP * tests * fix import * Clean up * added module docstring * renamed variables to be more descriptive * Added missing docstrings and type annotations * Added gym to example requirements * Added note to changelog * updated example image * update types * rename script * Update CHANGELOG.md Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com> * another rename * Disable validation when val_percent_check=0 (Lightning-AI#1251) * fix disable validation * add test * update changelog * update docs for val_percent_check * make "fast training" docs consistent * calling self.forward() -> self() (Lightning-AI#1211) * self.forward() -> self() * update changelog Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> * Fix requirements-extra.txt Trains package to release version (Lightning-AI#1229) * Fix requirement-extra use released Trains package * Update README.md add Trains and links to the external Visualization section Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> * Remove unnecessary parameters to super() in documentation and source code (Lightning-AI#1240) Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> * update deprecation warning (Lightning-AI#1258) * update docs for progress bat values (Lightning-AI#1253) * lower timeouts for inactive issues (Lightning-AI#1250) * update contrib list (Lightning-AI#1241) Co-authored-by: William Falcon <waf2107@columbia.edu> * Fix outdated docs (Lightning-AI#1227) * Fix typo (Lightning-AI#1224) * drop unused Tox (Lightning-AI#1242) * system info (Lightning-AI#1234) * system info * update big info * test script * update config * rename script * import path * Changed smoothing in tqdm to decrease variability of time remaining between training / eval (Lightning-AI#1194) * Example: Simple RL example using DQN/Lightning * DQN RL Agent using Lightning * Uses Iterable Dataset for Replay Buffer * Buffer is populated by agent as training is carried out, updating the dataset * Applied autopep8 fixes * * Updated line length from 120 to 110 * Update pl_examples/domain_templates/dqn.py simplify get_device method Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com> * Update pl_examples/domain_templates/dqn.py Re-ordered imports Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com> * Clean up * added module docstring * renamed variables to be more descriptive * Added missing docstrings and type annotations * Added gym to example requirements * Added note to changelog * update types * rename script * Update CHANGELOG.md Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com> * another rename Co-authored-by: Donal Byrne <Donal.Byrne@xperi.com> Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> Co-authored-by: William Falcon <waf2107@columbia.edu> Co-authored-by: Adrian Wälchli <adrian.waelchli@students.unibe.ch> Co-authored-by: Jeremy Jordan <13970565+jeremyjordan@users.noreply.github.com> Co-authored-by: Martin.B <51887611+bmartinn@users.noreply.github.com> Co-authored-by: Tyler Yep <tyep@stanford.edu> Co-authored-by: Shunta Komatsu <59395084+skmatz@users.noreply.github.com> Co-authored-by: Jack Pertschuk <jackpertschuk@gmail.com>

Jeremy Jordan added 2 commits March 22, 2020 18:47

self.forward() -> self()

fc00e52

update changelog

cc77ba9

jeremyjordan requested a review from a team March 23, 2020 00:07

williamFalcon approved these changes Mar 23, 2020

View reviewed changes

Borda added the feature Is an improvement or enhancement label Mar 23, 2020

Borda added this to the 0.7.2 milestone Mar 23, 2020

Borda approved these changes Mar 23, 2020

View reviewed changes

Borda added the ready PRs ready to be merged label Mar 23, 2020

Merge branch 'master' into docs/model-forward-best-practice

9833967

Borda removed the ready PRs ready to be merged label Mar 24, 2020

Borda changed the title ~~self.forward() -> self()~~ self.forward() -> self() [WIP] Mar 24, 2020

jeremyjordan changed the title ~~self.forward() -> self() [WIP]~~ [wip] self.forward() -> self() Mar 24, 2020

Merge branch 'master' into docs/model-forward-best-practice

09d59a6

awaelchli mentioned this pull request Mar 26, 2020

Design suggestion: remove forward from list of methods to override #838

Closed

Borda requested review from ethanwharris and a team March 26, 2020 10:18

Borda assigned williamFalcon Mar 26, 2020

ethanwharris approved these changes Mar 26, 2020

View reviewed changes

jeremyjordan changed the title ~~[wip] self.forward() -> self()~~ self.forward() -> self() Mar 27, 2020

Merge branch 'master' into docs/model-forward-best-practice

3156b96

Borda merged commit d394b80 into Lightning-AI:master Mar 27, 2020

Borda mentioned this pull request Mar 27, 2020

add TPU tests #1246

Closed

alexeykarnachev pushed a commit to alexeykarnachev/pytorch-lightning that referenced this pull request Apr 3, 2020

calling self.forward() -> self() (Lightning-AI#1211)

fc673fd

* self.forward() -> self() * update changelog Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>

Borda modified the milestones: v0.7., v0.7.x Apr 18, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

self.forward() -> self() #1211

self.forward() -> self() #1211

jeremyjordan commented Mar 22, 2020 •

edited

Loading

codecov bot commented Mar 22, 2020 •

edited

Loading

Borda left a comment

williamFalcon commented Mar 24, 2020

mergify bot commented Mar 24, 2020

jeremyjordan commented Mar 24, 2020

jeremyjordan commented Mar 25, 2020 •

edited

Loading

mergify bot commented Mar 25, 2020

ethanwharris left a comment

mergify bot commented Mar 27, 2020

mergify bot commented Mar 27, 2020

mergify bot commented Mar 27, 2020

mergify bot commented Mar 27, 2020

mergify bot commented Mar 27, 2020

jeremyjordan commented Mar 27, 2020

mergify bot commented Mar 27, 2020

Borda commented Mar 27, 2020 •

edited

Loading

self.forward() -> self() #1211

self.forward() -> self() #1211

Conversation

jeremyjordan commented Mar 22, 2020 • edited Loading

Before submitting

What does this PR do?

PR review

Did you have fun?

codecov bot commented Mar 22, 2020 • edited Loading

Codecov Report

Borda left a comment

Choose a reason for hiding this comment

williamFalcon commented Mar 24, 2020

mergify bot commented Mar 24, 2020

jeremyjordan commented Mar 24, 2020

jeremyjordan commented Mar 25, 2020 • edited Loading

mergify bot commented Mar 25, 2020

ethanwharris left a comment

Choose a reason for hiding this comment

mergify bot commented Mar 27, 2020

mergify bot commented Mar 27, 2020

mergify bot commented Mar 27, 2020

mergify bot commented Mar 27, 2020

mergify bot commented Mar 27, 2020

jeremyjordan commented Mar 27, 2020

mergify bot commented Mar 27, 2020

Borda commented Mar 27, 2020 • edited Loading

jeremyjordan commented Mar 22, 2020 •

edited

Loading

codecov bot commented Mar 22, 2020 •

edited

Loading

jeremyjordan commented Mar 25, 2020 •

edited

Loading

Borda commented Mar 27, 2020 •

edited

Loading