Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add TPU tests #1246

Closed
Borda opened this issue Mar 26, 2020 · 11 comments · Fixed by #2094 or #2486
Closed

add TPU tests #1246

Borda opened this issue Mar 26, 2020 · 11 comments · Fixed by #2094 or #2486
Assignees
Labels
accelerator: tpu Tensor Processing Unit ci Continuous Integration feature Is an improvement or enhancement good first issue Good for newcomers help wanted Open to be worked on
Milestone

Comments

@Borda
Copy link
Member

Borda commented Mar 26, 2020

🚀 Feature

we shall also cover TPU usage as we are supporting it

Motivation

now all changes are tested for GPUs and CPU but we do not have a check for TPU yet

Pitch

getting coverage back to ~99%

@Borda Borda added feature Is an improvement or enhancement help wanted Open to be worked on good first issue Good for newcomers ci Continuous Integration labels Mar 26, 2020
@awaelchli
Copy link
Member

TPU's are available in CI testing? Or are you saying there is a way to deploy it to colab?

@Borda
Copy link
Member Author

Borda commented Mar 26, 2020

TPU's are available in CI testing? Or are you saying there is a way to deploy it to colab?

not yet, by we will try to get one as we got also the GPUs some time ago :]

@Borda
Copy link
Member Author

Borda commented Mar 27, 2020

@jeremyjordan mind add optional TPU tests which would also help to you #1211 which would be helpful and simplify your testing...

@jeremyjordan
Copy link
Contributor

i'm probably not the best person for TPU tests, i haven't dug into that code much yet (and not sure if i'll have time in the upcoming week or two - want to make progress on #1099 this weekend)

@jeremyjordan jeremyjordan removed their assignment Mar 28, 2020
@luiscape
Copy link
Contributor

@Borda we could do TPU testing much like we do GPU testing, i.e. deploy a GCP instance with a CI system (e.g. Drone :) ) and then have it read a webook from GitHub. There are cost implications to that, but I think you can make that work.

Let's chat about how to make that happen. Maybe we can also get free credits from Google to test on TPUs?

@Borda
Copy link
Member Author

Borda commented Mar 28, 2020

Let's chat about how to make that happen. Maybe we can also get free credits from Google to test on TPUs?

That would be great! Just thinking coukd it be possible to have instance which has both - two GPUs and TPU in the same time?

@luiscape
Copy link
Contributor

I am not sure, actually. We'll have to look into it.

@Borda Borda added the accelerator: tpu Tensor Processing Unit label Apr 9, 2020
@lezwon
Copy link
Contributor

lezwon commented May 9, 2020

@Borda could we have something like this in lightning? pytorch/ignite#981

@Borda
Copy link
Member Author

Borda commented May 9, 2020

Yes, that is nice, the other option is to launch another instance of Drone.io

@lezwon
Copy link
Contributor

lezwon commented May 9, 2020

@Borda That's great. I'll be happy to take up this issue if we can get the CI system for TPU's set up. :)

@Borda
Copy link
Member Author

Borda commented May 9, 2020

Mind prepare in meantime tests for TPU and we prepare the test env :]

@Borda Borda self-assigned this May 9, 2020
@Borda Borda added the Important label Jun 1, 2020
@Borda Borda added this to Todo (next release) in Key features - Roadmap v1.0 Jun 1, 2020
@edenlightning edenlightning modified the milestones: 0.8.x, 0.9.0 Jun 18, 2020
Key features - Roadmap v1.0 automation moved this from Todo (next release) to Done Jun 23, 2020
@Borda Borda added this to Done in TPU testing Jul 7, 2020
@zcain117 zcain117 mentioned this issue Jul 23, 2020
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accelerator: tpu Tensor Processing Unit ci Continuous Integration feature Is an improvement or enhancement good first issue Good for newcomers help wanted Open to be worked on
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

6 participants