Add TRAINS experiment manager support #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…upport torch.Tensor to input into log_image
Add google style docstring & type hinting, fix bugs, improve PyTorch compatibility
|
Hello @bmartinn! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-03-13 01:19:08 UTC |
Borda
requested changes
Mar 11, 2020
pytorch_lightning/logging/trains.py
Outdated
| @@ -0,0 +1,5 @@ | |||
| """ | |||
There was a problem hiding this comment.
this is not needed, we have here just loggers which existed in the time we were using logging
There was a problem hiding this comment.
Should I remove the file all together ?
Borda
added
feature
Borda
changed the title
use logging fix typing and pep8
Borda
approved these changes
Mar 12, 2020
pytorch_lightning/loggers/trains.py
Outdated
|
|
||
| """ | ||
|
|
||
| import logging |
There was a problem hiding this comment.
Suggested change
| import logging | |
| import logging as log |
Borda
approved these changes
Mar 13, 2020
tullie
pushed a commit
to tullie/pytorch-lightning
that referenced
this pull request
Apr 3, 2020
* Add allegro.ai TRAINS experiment manager support * improve docstring and type hinting, fix the bug in log_metrics, add support torch.Tensor to input into log_image * complete missing docstring of constructor's arguments * fix docs * pep8 * pep8 * remove redundant typing use logging fix typing and pep8 * remove deprecated interface * add TrainsLogger test * add TrainsLogger PR in CHANGELOG * add id/name property documentation * change logging as log Co-authored-by: bmartinn <> Co-authored-by: Sou Uchida <s.aiueo32@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Extend the compatibility of pytorch-lightning logger to support the TRAINS experiment manager. #929
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Yes! 😄