Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TRAINS experiment manager support #929

Closed
bmartinn opened this issue Feb 24, 2020 · 6 comments · Fixed by #1122
Closed

Add TRAINS experiment manager support #929

bmartinn opened this issue Feb 24, 2020 · 6 comments · Fixed by #1122
Labels
feature Is an improvement or enhancement help wanted Open to be worked on let's do it! approved to implement logger Related to the Loggers

Comments

@bmartinn
Copy link
Contributor

bmartinn commented Feb 24, 2020

🚆 Add TRAINS experiment manager support

Integrate the TRAINS experiment manager with pytorch lightning.
Following TRAINS Issue #107

Motivation

Extend the compatibility of pytorch-lightning logger to support the TRAINS experiment manager.

Pitch

PR code can be reviewed here

@bmartinn bmartinn added feature Is an improvement or enhancement help wanted Open to be worked on labels Feb 24, 2020
@github-actions
Copy link
Contributor

Hey, thanks for your contribution! Great first issue!

@bmartinn
Copy link
Contributor Author

bmartinn commented Mar 6, 2020

Thanks to @S-aiueo32 + documentation and type hinting, details here

Dear PyTorch-Lightning Team, Could I push the PR?

@Borda
Copy link
Member

Borda commented Mar 10, 2020

@bmartinn sure, PR is welcome :]
cc: @PyTorchLightning/core-contributors

@Borda Borda added the let's do it! approved to implement label Mar 11, 2020
@Borda Borda linked a pull request Mar 11, 2020 that will close this issue
5 tasks
@Borda Borda changed the title Feature: Add TRAINS experiment manager support Add TRAINS experiment manager support Mar 12, 2020
@williamFalcon
Copy link
Contributor

@bmartinn this logger is causing a lot of issues. please fix asap, otherwise we'll have to remove it.

@Borda can you elaborate on the issues?

Traceback (most recent call last):
  File "/home/waf251/media/falcon_kcgscratch1/software/miniconda3/envs/pl10/lib/python3.7/threading.py", line 926, in _bootstrap_inner
    self.run()
  File "/home/waf251/media/falcon_kcgscratch1/software/miniconda3/envs/pl10/lib/python3.7/site-packages/trains/backend_interface/logger.py", line 197, in run
    while not self._exit_event.wait(period or 1.0):
  File "/home/waf251/media/falcon_kcgscratch1/software/miniconda3/envs/pl10/lib/python3.7/site-packages/trains/logger.py", line 522, in flush
    return self._task.flush()
  File "/home/waf251/media/falcon_kcgscratch1/software/miniconda3/envs/pl10/lib/python3.7/site-packages/trains/task.py", line 751, in flush
    LoggerRoot.flush()
  File "/home/waf251/media/falcon_kcgscratch1/software/miniconda3/envs/pl10/lib/python3.7/site-packages/trains/debugging/log.py", line 92, in flush
    h.flush()
  File "/home/waf251/media/falcon_kcgscratch1/software/miniconda3/envs/pl10/lib/python3.7/logging/__init__.py", line 1009, in flush
    self.stream.flush()
ValueError: I/O operation on closed file.

@bmartinn
Copy link
Contributor Author

bmartinn commented Apr 2, 2020

@williamFalcon is this on the master branch?
How do I reproduce it?
There is a fix for this PR on this branch and it was merged to the master here

@Borda
Copy link
Member

Borda commented Apr 3, 2020

@bmartinn pls see #1352

@Borda Borda added the logger Related to the Loggers label Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement help wanted Open to be worked on let's do it! approved to implement logger Related to the Loggers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants