Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pythainlp.morpheme #896

Merged
merged 4 commits into from
Jan 14, 2024
Merged

Add pythainlp.morpheme #896

merged 4 commits into from
Jan 14, 2024

Conversation

wannaphong
Copy link
Member

@wannaphong wannaphong commented Jan 1, 2024

Add pythainlp.morpheme for collect functions for morpheme analysis, word formation and more for Thai language.

  • pythainlp.morpheme.nighit: Nighit (นิคหิต or ํ ) is the niggahita in Thai language for create new words from Pali language in Thai. The function use simple method to create new Thai word from two words that the root is from Pali language.
  • Move pythainlp.util.is_native_thai to pythainlp.morpheme.is_native_thai 524759a

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Passed code styles and structures
  • Passed code linting checks and unit test

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@pep8speaks
Copy link

pep8speaks commented Jan 1, 2024

Hello @wannaphong! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-01-13 16:40:16 UTC

@coveralls
Copy link

coveralls commented Jan 1, 2024

Coverage Status

coverage: 85.509% (+0.03%) from 85.483%
when pulling dd64c25 on add-pythainlp.morpheme
into 1e94d32 on dev.

@wannaphong wannaphong changed the title [WIP] Add pythainlp.morpheme Add pythainlp.morpheme Jan 10, 2024
@wannaphong wannaphong marked this pull request as ready for review January 10, 2024 05:48
Copy link

sonarcloud bot commented Jan 13, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

8.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@wannaphong wannaphong merged commit ef1fb09 into dev Jan 14, 2024
14 of 18 checks passed
@wannaphong wannaphong added this to the 5.0 milestone Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants