phayathaibert, khavee, parse: Code clean up #889

bact · 2023-12-12T07:18:05Z

pythainlp.augment.lm.phayathaibert.ThaiTextAugmenter.augment(): Add exception if max num_args is exceeded, also guarantee return if work properly
pythainlp.phayathaibert.core.ThaiTextProcessor: Add self to argument of class methods
pythainlp.phayathaibert.core.ThaiTextProcessor: toks and pre_rules have to be List[str], not Collection[str] as the order matters.
pythainlp.parse.core.dependency_parsing(): model: str can't be None -> change to model: Union[str, None]
Khavee: membership test should be X not in, not not X in
Khavee: skip McCabe complexity check for now (54 complexity at the moment)

- `pythainlp.augment.lm.phayathaibert.ThaiTextAugmenter.augment()`: Add exception if max num_args is exceeded, also guarantee return if work properly - `Khavee`: skip McCabe complexity check for now (54 complexity at the moment) - `pythainlp.parse.core.dependency_parsing()`: model: str can't be None

pep8speaks · 2023-12-12T07:22:20Z

Hello @bact! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file pythainlp/khavee/core.py:

Line 231:13: W503 line break before binary operator
Line 232:13: W503 line break before binary operator
Line 233:13: W503 line break before binary operator
Line 238:13: W503 line break before binary operator
Line 239:13: W503 line break before binary operator
Line 327:13: W503 line break before binary operator
Line 329:17: W503 line break before binary operator
Line 345:13: W503 line break before binary operator
Line 397:29: W503 line break before binary operator
Line 398:29: W503 line break before binary operator
Line 399:29: W503 line break before binary operator
Line 419:21: W503 line break before binary operator
Line 420:21: W503 line break before binary operator
Line 421:21: W503 line break before binary operator
Line 422:21: W503 line break before binary operator
Line 437:33: W503 line break before binary operator
Line 443:33: W503 line break before binary operator
Line 444:33: W503 line break before binary operator
Line 454:33: W503 line break before binary operator
Line 460:33: W503 line break before binary operator
Line 461:33: W503 line break before binary operator
Line 473:37: W503 line break before binary operator
Line 479:37: W503 line break before binary operator
Line 480:37: W503 line break before binary operator
Line 503:29: W503 line break before binary operator
Line 504:29: W503 line break before binary operator
Line 505:29: W503 line break before binary operator
Line 518:21: W503 line break before binary operator
Line 519:21: W503 line break before binary operator
Line 520:21: W503 line break before binary operator
Line 521:21: W503 line break before binary operator
Line 536:33: W503 line break before binary operator
Line 542:33: W503 line break before binary operator
Line 543:33: W503 line break before binary operator
Line 553:33: W503 line break before binary operator
Line 559:33: W503 line break before binary operator
Line 560:33: W503 line break before binary operator
Line 572:37: W503 line break before binary operator
Line 578:37: W503 line break before binary operator
Line 579:37: W503 line break before binary operator

In the file pythainlp/parse/ud_goeswith.py:

Line 36:62: E203 whitespace before ':'
Line 64:17: W503 line break before binary operator
Line 113:21: W503 line break before binary operator

In the file pythainlp/phayathaibert/core.py:

Line 416:21: W503 line break before binary operator
Line 417:21: W503 line break before binary operator
Line 418:21: W503 line break before binary operator
Line 423:21: W503 line break before binary operator
Line 424:21: W503 line break before binary operator
Line 425:21: W503 line break before binary operator