Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pythainlp.util.to_idn #875

Merged
merged 6 commits into from
Dec 4, 2023
Merged

Add pythainlp.util.to_idn #875

merged 6 commits into from
Dec 4, 2023

Conversation

wannaphong
Copy link
Member

@wannaphong wannaphong commented Dec 3, 2023

What does this changes

Add pythainlp.util.to_idn for convert text to International Domain Name (IDN) for Thai domain name.

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Passed code styles and structures
  • Passed code linting checks and unit test

@pep8speaks
Copy link

pep8speaks commented Dec 3, 2023

Hello @wannaphong! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2023-12-04 13:00:42 UTC

@coveralls
Copy link

coveralls commented Dec 3, 2023

Coverage Status

coverage: 86.094% (-0.01%) from 86.104%
when pulling 4ef431a on add-thai_to_idn
into d213a8a on dev.

@wannaphong wannaphong added this to the 5.0 milestone Dec 3, 2023
@bact
Copy link
Member

bact commented Dec 3, 2023

The function name thai_to_idn can be more generic, as it can convert text in any Unicode-supported script.

I would suggest using utf8_to_idna, or just to_idna.

@wannaphong wannaphong changed the title Add pythainlp.util.thai_to_idn Add pythainlp.util.to_idn Dec 4, 2023
@wannaphong
Copy link
Member Author

The function name thai_to_idn can be more generic, as it can convert text in any Unicode-supported script.

I would suggest using utf8_to_idna, or just to_idna.

Done

@wannaphong wannaphong merged commit 7d77cc9 into dev Dec 4, 2023
5 of 14 checks passed
@wannaphong wannaphong deleted the add-thai_to_idn branch December 4, 2023 13:01
Copy link

sonarcloud bot commented Dec 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants