Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Thai word list from Volubilis dictionary #870

Merged
merged 10 commits into from
Dec 1, 2023
Merged

Add Thai word list from Volubilis dictionary #870

merged 10 commits into from
Dec 1, 2023

Conversation

konbraphat51
Copy link
Contributor

@konbraphat51 konbraphat51 commented Nov 30, 2023 •
edited by bact
Loading

What does this changes

Add an optional corpus of Volubilis titles.

  • thai_volubilis_words() function
  • license description

Fixes #858

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Passed code styles and structures
  • Passed code linting checks and unit test

@coveralls
Copy link

coveralls commented Nov 30, 2023 •
edited
Loading

Coverage Status

coverage: 86.071% (+3.0%) from 83.1%
when pulling 57b9e37 on konbraphat51:corpus_volubilis
into abfbf02 on PyThaiNLP:dev.

@konbraphat51
Copy link
Contributor Author

konbraphat51 commented Nov 30, 2023 •
edited
Loading

Not sure why coverall doesn't recognize test code of volubilis()

Edited: better now

@konbraphat51 konbraphat51 marked this pull request as ready for review November 30, 2023 05:01
@konbraphat51
Copy link
Contributor Author

Review please

@bact bact added corpus corpus/dataset-related issues enhancement enhance functionalities labels Nov 30, 2023
@bact bact added this to In progress in PyThaiNLP Nov 30, 2023
@bact bact self-requested a review November 30, 2023 15:38
bact
bact requested changes Nov 30, 2023
View reviewed changes
Copy link
Member

@bact bact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After updating license info, I think we are good to go.

pythainlp/corpus/corpus_license.md Outdated Show resolved Hide resolved
pythainlp/corpus/corpus_license.md Outdated Show resolved Hide resolved
@bact bact requested a review from wannaphong November 30, 2023 16:18
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@konbraphat51
Copy link
Contributor Author

Okey, review again please

@bact bact merged commit de098f3 into PyThaiNLP:dev Dec 1, 2023
10 of 14 checks passed
PyThaiNLP automation moved this from In progress to Done Dec 1, 2023
@bact bact mentioned this pull request Dec 6, 2023
Merged
2 tasks
@bact bact changed the title Add Volubilis corpus Add Thai word list from Volubilis dictionary Dec 15, 2023
@bact bact mentioned this pull request Dec 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bact bact bact approved these changes

@wannaphong wannaphong wannaphong approved these changes

Assignees
No one assigned
Labels
corpus corpus/dataset-related issues enhancement enhance functionalities
Projects
PyThaiNLP
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Suggestion] Add a large dictionary data
4 participants
@konbraphat51 @coveralls @bact @wannaphong