Add Thai word list from Thai Wikipedia titles #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for clarification
function to return frozen set of wikipedia titles. black used.
|
Review please |
obeying to code rules
|
Looks good to me. |
bact
added
corpus
bact
requested changes
Nov 30, 2023
bact
reviewed
Nov 30, 2023
pythainlp/corpus/corpus_license.md
Outdated
| ## Wikipedia Titles | ||
| Corpus of Wikipedia titles (wikipedia_titles.txt) was processed by konbraphat51 (https://github.com/konbraphat51/Thai_Dictionary_Cleaner/tree/main) | ||
|
|
||
| The original data is thwiki-latest-all-titles.gz of https://dumps.wikimedia.org/thwiki/latest/ which Wikipedia.org has created. |
There was a problem hiding this comment.
Do you mind to add date of the Wikipedia data here please?
The date that you have downloaded the data for your preparation.
There was a problem hiding this comment.
Yeah that's definitely required. Added!
|
Okey, review again please |
|
Ok, handled with the conflict! |
For standard licenses, like Creative Commons, just link to the license URL. No need to put the license text inside this file.
- sort imports - clean up test structure
|
Kudos, SonarCloud Quality Gate passed!
|
bact
approved these changes
Dec 1, 2023
|
Merged. Thank you. |
2 tasks
bact
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this changes
Add an optional corpus of Wikipedia titles.
Fixes #858
Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.