Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add function for pos tag with transformers #857

Merged
merged 5 commits into from
Nov 5, 2023

Conversation

MpolaarbearM
Copy link
Contributor

What does this changes

Add function to pos tagging using transformers in pos_tag.py. The function have 3 model which can be switch base on the name on the engine. Have test all engine on test_tag.py and there is no error. Also test assertRaise error value when the engine name does not match any of the engines name.

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • [ yes] Passed code styles and structures
  • [yes ] Passed code linting checks and unit test

@pep8speaks
Copy link

pep8speaks commented Nov 4, 2023

Hello @MpolaarbearM! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 223:19: W292 no newline at end of file

Line 376:95: W292 no newline at end of file

Comment last updated at 2023-11-05 07:37:06 UTC

@wannaphong wannaphong self-requested a review November 4, 2023 19:43
@wannaphong wannaphong linked an issue Nov 4, 2023 that may be closed by this pull request
@wannaphong wannaphong added this to the 4.1 milestone Nov 4, 2023
@wannaphong wannaphong added the enhancement enhance functionalities label Nov 4, 2023
@wannaphong wannaphong self-assigned this Nov 4, 2023
@wannaphong
Copy link
Member

@MpolaarbearM Can you fix pep8 and delete ptagger_temp4XcDf.json file?

@coveralls
Copy link

coveralls commented Nov 4, 2023

Coverage Status

coverage: 86.906% (+0.02%) from 86.883%
when pulling a2f5241 on MpolaarbearM:postag_transformers
into 715f700 on PyThaiNLP:dev.

@MpolaarbearM
Copy link
Contributor Author

@wannaphong yes I'll try and fix that

Copy link

sonarcloud bot commented Nov 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@wannaphong wannaphong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 💯

@wannaphong wannaphong merged commit d24dc2c into PyThaiNLP:dev Nov 5, 2023
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement enhance functionalities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TODO]: Train Part-of-speech corpus with transformers
4 participants