Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests of khavee functions #854

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Fix tests of khavee functions #854

merged 1 commit into from
Oct 23, 2023

Conversation

BLKSerene
Copy link
Contributor

@BLKSerene BLKSerene commented Oct 23, 2023

What does this changes

This PR fixes tests of khavee functions and conduct more code cleanups.

What was wrong

A regression is introduced when updating code comments and conducting code cleanups in #845.

How this fixes it

Extra space is added when joining parts of printed message to be consistent with other printed messages.

Fixes #853

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Passed code styles and structures
  • Passed code linting checks and unit test

@pep8speaks
Copy link

pep8speaks commented Oct 23, 2023

Hello @BLKSerene! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2023-10-23 08:56:15 UTC

@BLKSerene BLKSerene marked this pull request as draft October 23, 2023 08:27
@sonarcloud
Copy link

sonarcloud bot commented Oct 23, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
43.8% 43.8% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@BLKSerene BLKSerene marked this pull request as ready for review October 23, 2023 08:58
@wannaphong
Copy link
Member

Thank you! 💯

@wannaphong wannaphong merged commit e3a0177 into PyThaiNLP:dev Oct 23, 2023
9 of 14 checks passed
@wannaphong wannaphong added the hacktoberfest-accepted hacktoberfest accepted pull requests. label Oct 23, 2023
@wannaphong wannaphong added this to the 5.0 milestone Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted hacktoberfest accepted pull requests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: test_khavee.py failed - Can't find rhyme between paragraphs
3 participants