Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add syllable_tokenize #834

Merged
merged 2 commits into from
Aug 16, 2023
Merged

Add syllable_tokenize #834

merged 2 commits into from
Aug 16, 2023

Conversation

wannaphong
Copy link
Member

Add syllable_tokenize after deprecated syllable_tokenize in #322 #550

@wannaphong wannaphong marked this pull request as ready for review August 14, 2023 10:14
@sonarcloud
Copy link

sonarcloud bot commented Aug 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@wannaphong
Copy link
Member Author

wannaphong commented Aug 14, 2023 •
edited
Loading

After deprecated syllable tokenizer in #550, I found many user still want to use syllable_tokenize because the old document (from third party) still doesn't have up-to-date, so I think we should get syllable_tokenize back.

@coveralls
Copy link

coveralls commented Aug 14, 2023 •
edited
Loading

Coverage Status

coverage: 82.256% (-3.7%) from 85.941% when pulling 922e3cb on add-syllable_tokenize into d8b0325 on dev.

@wannaphong wannaphong added this to the 4.1 milestone Aug 16, 2023
@wannaphong wannaphong merged commit 1d7681d into dev Aug 16, 2023
13 of 16 checks passed
@wannaphong wannaphong deleted the add-syllable_tokenize branch December 4, 2023 13:01
@wannaphong wannaphong mentioned this pull request Feb 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@wannaphong @coveralls