Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rank and soundex handles empty or None case #151

Merged
merged 9 commits into from
Nov 6, 2018
Merged

rank and soundex handles empty or None case #151

merged 9 commits into from
Nov 6, 2018

Conversation

bact
Copy link
Member

@bact bact commented Nov 6, 2018 •
edited
Loading

  • handle empty or None cases in rank and soundex functions
  • add more test cases
  • remove if __name__ == "__main__"

@bact
remove WordNet wrapper (pythainlp/corpurs/wordnet.py) - the entire se…
27b7732 
…t of functions are exactly the same as nltk.wordnet, user can call nltk.wordnet by themselves.
@bact
Merge pull request #15 from PyThaiNLP/dev
32a718e 
Merge back
@bact
- rank() handles empty list or None case
7b3d077 
- add more test cases
- revert wordnet.py removal
@bact
more test case
7b18822
@bact bact requested a review from wannaphong November 6, 2018 07:58
@bact bact self-assigned this Nov 6, 2018
@coveralls
Copy link

coveralls commented Nov 6, 2018 •
edited
Loading

Coverage Status

Coverage increased (+2.2%) to 69.726% when pulling 3ed552e on bact:dev into 4c68a09 on PyThaiNLP:dev.

@bact bact changed the title rank() handles empty list or None case rank and soundex handles empty or None case Nov 6, 2018
@bact bact merged commit 580ea00 into PyThaiNLP:dev Nov 6, 2018
@wannaphong wannaphong mentioned this pull request Nov 6, 2018
Closed
@wannaphong wannaphong added this to the 1.8 milestone Nov 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wannaphong wannaphong wannaphong approved these changes

Assignees

@bact bact

Labels
None yet
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bact @coveralls @wannaphong