Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge different soundex systems to one pythainlp.soundex module #138

Merged
merged 6 commits into from
Oct 29, 2018
Merged

Merge different soundex systems to one pythainlp.soundex module #138

merged 6 commits into from
Oct 29, 2018

Conversation

bact
Copy link
Member

@bact bact commented Oct 29, 2018

  • Rename LK82 -> lk82, Udom83 -> udom83 (small case for function())
  • Moved all lk82, udom83, and metasound to pythainlp.soundex
  • Precompile regular expressions for lk82 and udom83
  • Adjust the tests

@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 58.269% when pulling f092f3e on bact:dev into c148699 on PyThaiNLP:dev.

@coveralls
Copy link

coveralls commented Oct 29, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.9%) to 58.621% when pulling e04323d on bact:dev into c148699 on PyThaiNLP:dev.

@wannaphong wannaphong added this to the 1.8 milestone Oct 29, 2018
@wannaphong wannaphong merged commit c76e786 into PyThaiNLP:dev Oct 29, 2018
@wannaphong wannaphong mentioned this pull request Nov 4, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wannaphong wannaphong wannaphong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bact @coveralls @wannaphong