Fix MetaSound + Adjust tokenizer selector + More documentation + clean code #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bact
commented
Oct 23, 2018
•
bact
commented
- fix MetaSound, follow algorithm in the Snae & Brückner (2009) paper
- update doc: pythainlp-dev-thai.md
- more details on word tokenizers
- add alias "longest" for "longest-matching" tokenizer
- remove "dict" tokenizer from document, as there is no implementation in the code
- remove "mm" tokenizer from document, as it is not recommended to use (maintenance mode), but keep the code, so people can run it
- remove unused imports
- more details on word tokenizers - add alias "longest" for longest-matching tokenizer - remove "dict" tokenizer from document, as there is no implementation in the code - remove "mm" tokenizer from document, as it is not recommended to use (maintenance mode), but keep the code, so people can call it - update doc: pythainlp-dev-thai.md - remove unused import sys
Merge from PyThaiNLp/pythainlp
- update doc
Add more MetaSound test
wannaphong
reviewed
Oct 23, 2018
- minor docs additions
Delete mkdocs.yml
- follow algorithm as explained in the paper Snae & Brückner (2009) https://pdfs.semanticscholar.org/3983/963e87ddc6dfdbb291099aa3927a0e3e4ea6.pdf - padding zeros to 4 characters length (default number, as specified in the paper) - retain the first alphabet - rename MetaSound to metasound (small caps function naming convention) - remove the use of regex
bact
changed the title
wannaphong
reviewed
Oct 23, 2018
bact
changed the title
|
เปลี่ยนชื่อเรียบร้อยครับ เหมือนพอมันเป็นชื่อเดียวกันแต่ต่างแค่ตัวเล็กตัวใหญ่แล้วตัว git มองไม่เห็นว่ามันเปลี่ยน |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.