Clean code (/corpus, /tools, /ulmfit) #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bact
commented
Oct 20, 2018
bact
commented
- put corpus database url into CORPUS_DB_URL constant
- sort imports, remove unused imports
- add __ prefix for private class members
- precompile patterns at initialization (ThaiTokenizer class)
- use "not" for condition comparison (in a reasonable situation) with booleans (as suggested by PEP8)
- make indent more consistent
- sort imports, remove unused imports - add __ prefix for private member - precompile patterns at initialization (ThaiTokenizer class) - use "not" for condition comparison (in a reasonable situation) with booleans (as suggested by PEP8) - make indent more consistent
wannaphong
approved these changes
Oct 20, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.