Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix processing but of further_description from manual_input.csv and 'solar', 'solar-rooftop' description #88

Merged
merged 4 commits into from
May 10, 2023

Conversation

euronion
Copy link
Collaborator

Changes proposed in this Pull Request

  • Fix source and further description for solar and solar-rooftop to indicate where these numbers are really coming from (not DEA TD) (h/t to @awongel for pointing out this issue)
  • Fix a bug where further_description from manual_inputs.csv was not correctly parsed into the output files.

Checklist

  • Code changes are sufficiently documented; i.e. new functions contain docstrings and further explanations may be given in doc.
  • Data source for new technologies is cleary stated.
  • [n/a] Newly introduced dependencies are added to environment.yaml (if applicable).
  • A note for the release notes doc/release_notes.rst of the upcoming release is included.
  • I consent to the release of this PR's code under the GPLv3 license.

@euronion euronion requested a review from lisazeyen May 10, 2023 07:48
@lisazeyen
Copy link
Collaborator

Thanks a lot @euronion !

@lisazeyen lisazeyen merged commit 52bdf1b into master May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants