-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change reference cost year to 2020 #121
Conversation
@aleks-g and @koen-vg have used real inflation data instead of
Don't know though if that was done afterwards or directly in a fork of |
Hi Fabian, we've only included inflation since 2015 in the analysis/post-processing afterwards, without adapting anything in technology-data itself. :) |
I guess it make sense to take the actual inflation. I downloaded the annual inflation from eurostat and would add this instead of assuming 2% inflation for every year |
We haven't checked all technologies yet in DEA, but I think we can already pull it in and open another issue that all single DEA technologies should be double checked for the correct currency year. |
I have to say I'm a little bit confused by the Eurostat dataset browser sometimes because it sometimes includes and sometimes doesn't include 2023. But here it seems possible to get a dataset in the same format with 2023 included? https://ec.europa.eu/eurostat/databrowser/view/prc_hicp_aind__custom_9900786/default/table?lang=en I think it would be nice to have as recent as possible data available, and there are now inflation values for 2023 (namely, 6.4%). Apart from that, thanks a bunch for this work! |
Good idea to include 2023, unfortunately the data you are linking to is only dating back to 2015 and it would be nice to have the earlier years in there as well. I have added 2023 now within the function when preparing the data (not the nicest way, but at least 2023 is included now as well)... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good. Some column headers were removed and there were some local file paths added, and we should link the source for the inflation data.
Did you do a few spot checks whether the adjustments made sense in outputs
? If yes, I am happy for this to be merged.
Regarding the range of inflation data available, if the other dataset (dating back pre-2015) is not updated, we can think about merging the two sources.
Let's do the following spot checks:
|
Looking at projections for 2020 and comparing data as named in the original source with the outputs of the technology data
Let's do some example calculations e.g. for H2 pipelines |
You could use the OECD data repository instead, they list HICP since 1991 for the current EURO area and allow for download as CSV or by API access: |
they are mentioning as source Eurostat (=. |
@fneum I compared now the original data input with the cost adjusted values. Comparing the old and new costs is not very insightful since many of the input data previously was not inflation adjusted. One thing to double check, I am basically assuming now when converting e.g. Eur_2017 to Eur_2020 the inflation of the three year 2018, 2019, 2020, since Eur_2017 should consider already the inflation for 2017 right? |
I think either way is fine, just it cannot be 2017, 2018, 2019, 2020. |
Closes # (if applicable).
Changes proposed in this Pull Request
Change the reference cost year to 2020, closes issue #118
currency_year
is added which represents the currency year of the original input dataChecklist
add annual inflation from eurostat
@JulianGeis one would need to go through all the techs listed here and double check the reference cost year. All the techs with cost year 2020 should be added to the list here
add reference year for vehicle costs
Code changes are sufficiently documented; i.e. new functions contain docstrings and further explanations may be given in
doc
.Data source for new technologies is cleary stated.
Newly introduced dependencies are added to
environment.yaml
(if applicable).A note for the release notes
doc/release_notes.rst
of the upcoming release is included.I consent to the release of this PR's code under the GPLv3 license.