Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacing the IGGIELNG_LNG data with Europe-Gas-Tracker #289

Merged
merged 11 commits into from
Feb 16, 2023
Merged

Replacing the IGGIELNG_LNG data with Europe-Gas-Tracker #289

merged 11 commits into from
Feb 16, 2023

Conversation

FabianHofmann
Copy link
Collaborator

No description provided.

virio-andreyana and others added 2 commits December 29, 2022 12:14
@virio-andreyana
Appending comments for gas_input_locations
0cb0ad5
@virio-andreyana
Update scripts/build_gas_input_locations.py
da6469b 
Co-authored-by: Fabian Hofmann <hofmann@fias.uni-frankfurt.de>
@FabianHofmann FabianHofmann marked this pull request as ready for review January 11, 2023 09:08
@fneum
Copy link
Member

fneum commented Feb 15, 2023

Should I review this @FabianHofmann, @virio-andreyana?

@FabianHofmann
Copy link
Collaborator Author

yes that would be good

@fneum fneum added this to the Release 0.7 milestone Feb 16, 2023
@virio-andreyana
Copy link
Collaborator

Thanks @fneum for merging 'master' into the branch. I still had some code that needs to be ammend before its done. mainly to do with the missunderstanding snakemake has with HTTP links. Will be done tomorrow

@fneum
Copy link
Member

fneum commented Feb 16, 2023

image

Before/after looks good!

@fneum
Copy link
Member

fneum commented Feb 16, 2023

Ah, sorry @virio-andreyana! I thought you were already done. I am currently doing a release and wanted to include this PR. I just pushed some cosmetic changes, but it already looks very good and can be included in the upcoming release.

Have a look at ece64a7 what I changed.

  • I think you accidentally removed the retrieve_gas_infrastructure_data rule
  • The retrieve_gas_input_locations was no longer needed.
  • Use of Snakemake's HTTP.remote over direct pandas URL interface. In this way, snakemake can also run offline once downloaded.
  • Renamed the conversion factors from MCM/d and Mtpa.

@fneum fneum merged commit 8e74ee6 into master Feb 16, 2023
@virio-andreyana
Copy link
Collaborator

Thanks @fneum!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
before-merge-march
Projects
None yet
Milestone
Release 0.7
Development

Successfully merging this pull request may close these issues.
3 participants
@FabianHofmann @fneum @virio-andreyana