Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use dask.array functions instead of numpy #367

Merged
merged 3 commits into from
Sep 8, 2024
Merged

use dask.array functions instead of numpy #367

merged 3 commits into from
Sep 8, 2024

Conversation

fneum
Copy link
Member

@fneum fneum commented Aug 5, 2024

I had hoped for some performance gains, but this is not so clear.

@euronion
Copy link
Collaborator

euronion commented Aug 6, 2024

NB:
Most of the dask functions you have changed are just calls to the same numpy functions using ufunc, see the "direct" entries here: https://docs.dask.org/en/stable/array-numpy-compatibility.html#compatibility-with-numpy-functions .

Changing does give a bit of consistency, I'm not opposed.

@fneum fneum merged commit 74e961f into master Sep 8, 2024
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants