Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 64-bit RISC-V support #1001

Merged
merged 1 commit into from
Jul 10, 2022
Merged

Add 64-bit RISC-V support #1001

merged 1 commit into from
Jul 10, 2022

Conversation

felixonmars
Copy link
Contributor

Tested with orjson and it built fine with all tests passed on a
riscv64 machine.

This change is not sufficient though, because ring doesn't support
riscv64 yet. I was building maturin against a custom version of ring
to verify this change.

Please let me know what could be done to move forward :)

Tested with `orjson` and it built fine with all tests passed on a
riscv64 machine.

This change is not sufficient though, because `ring` doesn't support
riscv64 yet. I was building `maturin` against a custom version of `ring`
to verify this change.

Please let me know what could be done to move forward :)
@netlify
Copy link

netlify bot commented Jul 10, 2022

Deploy Preview for maturin-guide canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 98e2515
🔍 Latest deploy log https://app.netlify.com/sites/maturin-guide/deploys/62ca1e9334598a000cd09137

@messense
Copy link
Member

messense commented Jul 10, 2022

Thanks, please run cargo fmt.

Copy link
Member

@messense messense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix the code format issue after merging.

@messense messense merged commit 1642ddc into PyO3:main Jul 10, 2022
@felixonmars felixonmars deleted the riscv64 branch July 10, 2022 02:25
@felixonmars
Copy link
Contributor Author

I'll fix the code format issue after merging.

Thanks! I was about to do it :P

messense added a commit that referenced this pull request Jul 10, 2022
@messense
Copy link
Member

messense commented Jul 10, 2022

Since ring doesn't support RISC-V yet, we should also add it to

maturin/setup.py

Lines 49 to 52 in 1339808

if platform.machine() in ("ppc64le", "ppc64", "powerpc") or (
sys.platform == "win32" and platform.machine() == "ARM64"
):
cargo_args.extend(["--no-default-features", "--features=upload,log,human-panic"])

@felixonmars do you know what does platform.machine() return on 64-bit RISC-V?

@felixonmars
Copy link
Contributor Author

what does platform.machine() return on 64-bit RISC-V?

>>> platform.machine()
'riscv64'

felixonmars added a commit to felixonmars/archriscv-packages that referenced this pull request Jul 10, 2022
add-riscv64-support.patch was backported from
PyO3/maturin#1001
felixonmars added a commit to felixonmars/archriscv-packages that referenced this pull request Jul 10, 2022
add-riscv64-support.patch was backported from
PyO3/maturin#1001
@messense
Copy link
Member

Released in v0.13.1.

@messense messense mentioned this pull request Jul 27, 2022
5 tasks
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Aug 8, 2022
https://build.opensuse.org/request/show/991319
by user mia + dimstar_suse
- Update to v0.13.1
  * Add 64-bit RISC-V support
    gh#PyO3/maturin#1001
  * Run tests on CI with cargo-nextest
    gh#PyO3/maturin#1004
  * Add support for invoking with python3 -m maturin
    gh#PyO3/maturin#1008
  * Consider pyproject.toml features when detecting pyo3
    gh#PyO3/maturin#1014
  * Respect user specified Rust target in maturin develop
    gh#PyO3/maturin#1016
  * Use cargo rustc --crate-type cdylib on Rust nightly/dev channel
    gh#PyO3/maturin#1020
  * Use cargo-nextest in test-alpine
    gh#PyO3/maturin#1021
-  Update to v0.13.0
  * Drop python 3.6 by @konstin in #945
  * Add support for building with multiple binary targets by
    @messense in #948
  * Add a --target option to maturin list-python command by
    @messense in #957
  * Add support for using bundled pyth
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants