fix: resolve configuration file precedence issue #252
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package searches its configuration in some standard config files following a strict order:
pyproject.toml
setup.cfg
tox.ini
That's great as enables variety of config schemes. The problem is that the searching loop is broken when it finds the file, not the actual configuration in it. So, if you want to define configuration in
setup.cfg
, but have other tool (e.g.,black
in my case) configured inpyproject.toml
(or even if you define project metadata in that file, following PEP 621),docformatter
does not see the desired settings.In this PR, I propose a simple update of
configuration.Configurater
class constructor to resolve this issue.