Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle index error in link wrapping #141

Merged
merged 4 commits into from
Dec 29, 2022
Merged

fix: handle index error in link wrapping #141

merged 4 commits into from
Dec 29, 2022

Conversation

weibullguy
Copy link
Member

This pull request:

  • Skips link handling when there is nothing wrapped in the original text.
  • Maintains wraps when the link is short enough to be contained on a single line along with additional words.

Closes #140

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3797986200

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%
Totals Coverage Status
Change from base Build 3725906095: 0.0%
Covered Lines: 0
Relevant Lines: 0
💛 - Coveralls

@weibullguy weibullguy mentioned this pull request Dec 29, 2022
Closed
@weibullguy weibullguy merged commit ee4bfe3 into master Dec 29, 2022
@weibullguy weibullguy deleted the fix/issue-139 branch December 29, 2022 03:12
@weibullguy weibullguy added the S: merged Closed with work merged to repository label Dec 29, 2022
@weibullguy weibullguy added P: bug PEP 257 violation or existing functionality that doesn't work as documented C: style Relates to docstring format style (e.g., Google, NumPy, Sphinx) labels Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C: style Relates to docstring format style (e.g., Google, NumPy, Sphinx) P: bug PEP 257 violation or existing functionality that doesn't work as documented S: merged Closed with work merged to repository
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bugs in link handling in 1.5.1
2 participants
@weibullguy @coveralls