Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Csv kwargs #36

Merged
merged 3 commits into from
Oct 17, 2024
Merged

Remove Csv kwargs #36

merged 3 commits into from
Oct 17, 2024

Conversation

jukent
Copy link
Contributor

@jukent jukent commented Oct 17, 2024

In favor of #35 which has other changes in it.
Closes #33

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 17, 2024 •
edited
Loading

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: 3e8c3e1
✅ Deployment Preview URL: https://ProjectPythia.github.io/intake-cookbook/_preview/36

@jukent jukent mentioned this pull request Oct 17, 2024
Closed
erogluorhan
erogluorhan approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@erogluorhan erogluorhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

@jukent jukent merged commit 700a7d2 into main Oct 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erogluorhan erogluorhan erogluorhan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Builds failing on intake.open_csv()
2 participants
@jukent @erogluorhan