Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builds failing on intake.open_csv() #33

Closed
brian-rose opened this issue Mar 27, 2024 · 7 comments · Fixed by #36
Closed

Builds failing on intake.open_csv() #33

brian-rose opened this issue Mar 27, 2024 · 7 comments · Fixed by #36
Labels
infrastructure Infrastructure related issue

Comments

@brian-rose
Copy link
Member

As of last month, the nightly build is failing

Failure occurs on the line

source = intake.open_csv('inventory.csv', csv_kwargs={'keep_default_na': False})

with

AttributeError: Unknown open method 'open_csv'. Do you need to install a new driver from the plugin directory? https://intake.readthedocs.io/en/latest/plugin-directory.html
Registered opener methods: ['open_netcdf', 'open_opendap', 'open_rasterio', 'open_remote-xarray', 'open_xarray_image', 'open_zarr', 'open_markdown', 'open_yaml_file_cat', 'open_yaml_files_cat', 'open_remote_xarray']

The timing of the failure seems to coincide with the release of Intake 2.0.

From the Intake docs, one of the features that was removed in 2.0 included

  • some niche source features such as CSV file pattern matching

The short term fix is probably just to pin to Intake < 2.0

@brian-rose brian-rose added the infrastructure Infrastructure related issue label Mar 27, 2024
@brian-rose
Copy link
Member Author

I started looking at this because of an apparent issue with Intake in the xbatcher-ML-1 cookbook

@brian-rose
Copy link
Member Author

However, since the purpose of this Cookbook is to demonstrate Intake usage, it doesn't make much sense to keep it pinned to an old version of Intake.

@brian-rose
Copy link
Member Author

Any thoughts on this @jnmorley ?

@erogluorhan
Copy link
Member

@jukent you seem to have the second largest contributions to this cookbook (I know they were mostly on configs and repair though). We are pinging the authors of failing cookbooks; would you mind having a look at this one as there has been no response from @jnmorley yet?

@jukent
Copy link
Contributor

jukent commented Oct 17, 2024

Thanks @erogluorhan I'll look into this today.

This was referenced Oct 17, 2024
@jukent
Copy link
Contributor

jukent commented Oct 17, 2024

Build passing!

@erogluorhan
Copy link
Member

Thanks a lot for quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Infrastructure related issue
Projects
Status: Done
3 participants