Fix full screen mode issue where modals windows do not open in the foreground #3908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerdesque
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently an issue with full screen mode where modal windows, when triggered, do not open in the foreground as expected. Instead, they open in the background and are only visible after leaving full screen mode. This results in a poor user experience, as users cannot interact with the modals while in full screen mode. This pull request aims to address and fix this issue. We will ensure that modals always open in the user's immediate view, regardless of mode.
To do this, I have replaced the current react-fullscreen library with a custom fscreen handle component. This was suggested in the following issue of react-fullscreen, see snakesilk/react-fullscreen#63 (comment)
Current:
fullscreen_modal_not_working.webm
New:
fullscreen_modal_working.webm