Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix output node port removal #80

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Fix output node port removal #80

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d2567c
fix input multi connections on disconnect
RichardFrangenberg Jul 8, 2024
13b1ad5
fix output node port removal when disconnecting in some ways
RichardFrangenberg Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/QuiltiX/qx_node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -639,7 +639,7 @@ def on_output_connected(self, in_port, out_port):
ng_port.view.setToolTip(out_port.view.get_mx_port_type())

def on_output_disconnected(self, in_port, out_port):
if not getattr(self.graph, "is_collapsing", False):
if not getattr(self.graph, "is_collapsing", False) and not in_port.connected_ports():
self.graph.node.get_input(in_port.name()).clear_connections()
self.graph.node.delete_input(in_port.name())
del self.properties()["custom"][f"Input #{self.output_ports().index(in_port) + 1}"]
Expand Down Expand Up @@ -760,9 +760,6 @@ def on_input_connected(self, in_port, out_port):
def on_input_disconnected(self, in_port, out_port):
if getattr(self.graph, "is_collapsing", False):
return

if self.graph._viewer._start_port:
return # is in a live connection

self.graph.node.get_output(in_port.name()).clear_connections()
self.graph.node.delete_output(in_port.name())
Expand Down